Extend #69020 test to include reversed operand order. #70696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we check the case where the generic operand comes first, in case any future changes make this ordering matter.
rust-highfive
added
the
S-waiting-on-review
jumbatm
changed the title
RalfJung
reviewed
Apr 2, 2020
src/test/ui/associated-const/issue-69020-assoc-const-arith-overflow.rs
Outdated
Show resolved
Hide resolved
Also, fix the goofy reversed names with something clearer.
|
This looks great, thanks a lot! |
|
📌 Commit 0399d14 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#70696 (Extend rust-lang#69020 test to include reversed operand order.) - rust-lang#70706 (Minor cleanup in rustdoc --check-theme) - rust-lang#70725 (Avoid `.unwrap()`s on `.span_to_snippet(...)`s) - rust-lang#70728 (Minor doc improvements on `AllocRef`) - rust-lang#70730 (Fix link in task::Wake docs) - rust-lang#70731 (Minor follow-up after renaming librustc(_middle)) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we still emit if a lint if the generic argument comes first. See #70566 (comment).
r? @RalfJung